Class TestResponseValidator

tests/test_control_layer.py:188–245

# =============================================================================

class TestResponseValidator:

    def setup_method(self):
        self.validator = ResponseValidator()

    def test_empty_response_fails(self):
        schema = ResponseSchema()
        result = self.validator.validate("", schema)
        assert result.passed is False
        assert result.failure_mode == FailureMode.CONSTRAINT_VIOLATION

    def test_valid_json_passes(self):
        schema = ResponseSchema(must_be_json=True, required_keys=["key"])
        result = self.validator.validate('{"key": "value"}', schema)
        assert result.passed is True

    def test_invalid_json_fails(self):
        schema = ResponseSchema(must_be_json=True)
        result = self.validator.validate("not json", schema)
        assert result.passed is False
        assert result.failure_mode == FailureMode.SCHEMA_VIOLATION

    def test_missing_required_key_fails(self):
        schema = ResponseSchema(must_be_json=True, required_keys=["missing_key"])
        result = self.validator.validate('{"other": "value"}', schema)
        assert result.passed is False
        assert result.failure_mode == FailureMode.SCHEMA_VIOLATION

    def test_max_length_enforced(self):
        schema = ResponseSchema(max_length=10)
        result = self.validator.validate("This is longer than ten characters.", schema)
        assert result.passed is False

    def test_min_length_enforced(self):
        schema = ResponseSchema(min_length=50)
        result = self.validator.validate("Too short.", schema)
        assert result.passed is False

    def test_forbidden_phrase_blocked(self):
        schema = ResponseSchema(forbidden_phrases=["I cannot"])
        result = self.validator.validate("I cannot help with that.", schema)
        assert result.passed is False

    def test_json_with_markdown_fencing_passes(self):
        schema = ResponseSchema(must_be_json=True, required_keys=["key"])
        result = self.validator.validate('```json\n{"key": "value"}\n```', schema)
        assert result.passed is True

    def test_quality_score_calculated(self):
        schema = ResponseSchema(must_contain=["token", "budget"])
        result = self.validator.validate("token budget allocation", schema)
        assert result.passed is True
        assert result.score == 1.0

    def test_partial_quality_score(self):
        schema = ResponseSchema(must_contain=["token", "budget"])
        result = self.validator.validate("only token here", schema)
        assert result.score == 0.5