Method RemoveDynaFedMaskOnSerialize

src/chain.h:469–477

ELEMENTS: to unmask the dynafed bit on deserialization, we call one of these these methods from SERIALIZE_METHODS, using const-overloading to select the right one. We cannot inline them since the body of SERIALIZE_METHODS will be called with a const object during serialization. See Core #17850 and followups.

    //  right one. We cannot inline them since the body of SERIALIZE_METHODS will be
    //  called with a const object during serialization. See Core #17850 and followups.
    bool RemoveDynaFedMaskOnSerialize(bool for_read) {
        if (for_read) {
            bool is_dyna = nVersion < 0;
            nVersion = (int32_t) (~CBlockHeader::DYNAFED_HF_MASK & (uint32_t)nVersion);
            return is_dyna;
        } else {
            return is_dynafed_block();
        }
    }
    bool RemoveDynaFedMaskOnSerialize(bool for_read) const {
        assert(!for_read);
        return is_dynafed_block();