Function assertEnvRegistryConsistent

showcase/scripts/railway-envs.ts:2423–2505

(
  services: Record<
    string,
    { environments?: Record<string, unknown> }
  > = SERVICES,
  envIdByName: Record<string, string> = ENV_ID_BY_NAME,
  envIds: Record<string, string> = ENV_IDS,
)

 * Accepts injected maps for testing; defaults to the real registries.
 */
export function assertEnvRegistryConsistent(
  services: Record<
    string,
    { environments?: Record<string, unknown> }
  > = SERVICES,
  envIdByName: Record<string, string> = ENV_ID_BY_NAME,
  envIds: Record<string, string> = ENV_IDS,
): void {
  const problems: string[] = [];
  for (const [key, entry] of Object.entries(services)) {
    for (const env of Object.keys(entry.environments ?? {})) {
      if (!Object.hasOwn(envIdByName, env)) {
        problems.push(
          `  - service "${key}" declares env "${env}", which is not a canonical env name in ENV_ID_BY_NAME — no accessor or redeploy path could ever resolve it`,
        );
      }
    }
  }
  const byId = new Map<string, string>(); // env-id -> first canonical name
  for (const [name, id] of Object.entries(envIdByName)) {
    const prior = byId.get(id);
    if (prior !== undefined) {
      problems.push(
        `  - duplicate env-id "${id}" in ENV_ID_BY_NAME (canonical names: ${prior}, ${name}) — resolveEnv resolves the FIRST name, silently shadowing the second`,
      );
    } else {
      byId.set(id, name);
    }
  }
  const spelledIds = new Set(Object.values(envIds));
  for (const [name, id] of Object.entries(envIdByName)) {
    if (!spelledIds.has(id)) {
      problems.push(
        `  - canonical env "${name}" (env-id "${id}") has no ENV_IDS spelling — resolveEnv can never produce it; register at least its own name in ENV_IDS`,
      );
    }
  }
  // (iv) Cross-wire: a key in BOTH registries must carry the SAME env-id.
  for (const [key, id] of Object.entries(envIds)) {
    if (Object.hasOwn(envIdByName, key) && envIdByName[key] !== id) {
      problems.push(
        `  - cross-wired env "${key}": ENV_IDS maps it to "${id}" but ENV_ID_BY_NAME maps it to "${envIdByName[key]}" — resolveEnv("${key}") would silently resolve to the OTHER env`,
      );
    }
  }
  // (v) Orphan spelling: every ENV_IDS env-id must have a canonical name.
  const canonicalIds = new Set(Object.values(envIdByName));
  for (const [spelling, id] of Object.entries(envIds)) {
    if (!canonicalIds.has(id)) {
      problems.push(
        `  - orphan ENV_IDS spelling "${spelling}": its env-id "${id}" is carried by no ENV_ID_BY_NAME canonical name — resolveEnv would reject it only lazily at call time`,
      );
    }
  }
  // (vi)+(vii) Key hygiene on both registries: lowercase-normalized and
  // never an Object.prototype property name.
  const protoNames = new Set(Object.getOwnPropertyNames(Object.prototype));
  const registries: Array<[string, Record<string, string>]> = [