Class TestIssuesIdentified

tests/unit/test_all_embedders.py:371–414

Test the specific issues identified in the codebase.

class TestIssuesIdentified:
    """Test the specific issues identified in the codebase."""
    
    def test_binary_assumptions_in_rag(self):
        """Test that RAG doesn't make binary assumptions about embedders."""
        from api.rag import RAG
        
        # The current implementation only considers is_ollama_embedder
        # This test documents the current behavior and will help verify fixes
        try:
            rag = RAG()
            
            # Current implementation only has is_ollama_embedder
            assert hasattr(rag, 'is_ollama_embedder'), "RAG should have is_ollama_embedder"
            
            # This is the issue: no explicit support for Google embedder detection
            # The fix should add proper embedder type detection
            
        except Exception as e:
            logger.warning(f"RAG test failed: {e}")

    def test_binary_assumptions_in_data_pipeline(self):
        """Test binary assumptions in data pipeline functions."""
        from api.data_pipeline import prepare_data_pipeline, count_tokens
        
        # These functions currently only consider is_ollama_embedder parameter
        # This test documents the issue and will verify fixes
        
        # count_tokens only considers ollama vs non-ollama
        token_count_ollama = count_tokens("test", is_ollama_embedder=True)
        token_count_other = count_tokens("test", is_ollama_embedder=False)
        
        assert isinstance(token_count_ollama, int)
        assert isinstance(token_count_other, int)
        
        # prepare_data_pipeline only accepts is_ollama_embedder parameter
        try:
            pipeline_ollama = prepare_data_pipeline(is_ollama_embedder=True)
            pipeline_other = prepare_data_pipeline(is_ollama_embedder=False)
            
            assert pipeline_ollama is not None
            assert pipeline_other is not None
        except Exception as e:
            logger.warning(f"Pipeline creation failed: {e}")


def run_all_tests():