Function validate_note_plan

scripts/lint_grounding.py:197–258

(
    note_plan: dict[str, Any],
    source_manifest: dict[str, Any],
)

def validate_note_plan(
    note_plan: dict[str, Any],
    source_manifest: dict[str, Any],
) -> list[dict[str, Any]]:
    issues: list[dict[str, Any]] = []
    for field in NOTE_PLAN_REQUIRED_FIELDS:
        if field not in note_plan:
            issues.append(issue("note_plan_required_field_missing", field=field))
    for field in NOTE_PLAN_STRING_FIELDS:
        if field in note_plan and not normalize_whitespace(str(note_plan.get(field, ""))):
            issues.append(issue("note_plan_required_field_empty", field=field))
    for field in NOTE_PLAN_LIST_FIELDS:
        value = note_plan.get(field)
        if field in note_plan and (not isinstance(value, list) or not value):
            issues.append(issue("note_plan_required_field_empty", field=field))

    paper_type = normalize_whitespace(str(note_plan.get("paper_type", "")))
    if paper_type not in PAPER_TYPE_VALUES:
        issues.append(issue("note_plan_paper_type_invalid", paper_type=paper_type))

    if source_is_truncated(source_manifest) and not accepts_partial_reading(note_plan):
        issues.append(issue("source_manifest_truncated_without_partial_acceptance"))

    valid_ids = source_section_ids(source_manifest)
    max_page = total_pages(source_manifest)
    required_sections = set(WRITING_CONTRACT_RULES["grounding_required_sections"])
    grounded_sections: set[str] = set()
    section_plan = note_plan.get("section_plan", [])
    if not isinstance(section_plan, list):
        issues.append(issue("note_plan_section_plan_invalid"))
        return issues

    for item in section_plan:
        if not isinstance(item, dict):
            issues.append(issue("note_plan_section_plan_item_invalid"))
            continue
        section_name = normalize_whitespace(
            str(item.get("section") or item.get("name") or item.get("heading") or "")
        )
        if section_name in required_sections:
            grounded_sections.add(section_name)
        sources = evidence_sources(item)
        if section_name in required_sections and not sources:
            issues.append(issue("section_plan_grounding_missing", section=section_name))
            continue
        if section_name in required_sections and not focus_is_substantive(
            section_focus_text(item)
        ):
            issues.append(issue("section_plan_focus_too_thin", section=section_name))
        for source in sources:
            for code in source_grounding_errors(source, valid_ids, max_page):
                issues.append(issue(code, section=section_name, source=source))

    for section_name in sorted(required_sections - grounded_sections):
        issues.append(issue("section_plan_required_section_missing", section=section_name))

    issues.extend(validate_central_claims(note_plan, valid_ids, max_page))